[chore][cmd/otelcontribcol] Exclude from linter #27865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
added
cmd/otelcontribcol
|
For some context and a relevant example of why this is necessary, I'm adding eks cluster name detection to the resource detection processor (#27408), and lint is failing every time either on timeouts or overloading the GitHub CI runner. |
atoulme
approved these changes
Oct 19, 2023
|
Looks like that helped some. If you get in trouble again, adding |
dmitryax
approved these changes
Oct 19, 2023
martin-majlis-s1
pushed a commit
to scalyr/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
**Description:** The linter runs are taking longer and longer as more components and dependencies are added, it's preferable to simply run on each individual component. **Link to tracking Issue:** Related: open-telemetry#27850
codeboten
pushed a commit
that referenced
this pull request
Oct 20, 2023
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Same idea as #27865, remove generated code from being linted. The linter is taking longer and longer to run as more components and dependencies are added. This change is to remove unnecessary modules from being linted, which will help reduce runtime and resources required. **Link to tracking Issue:** <Issue number if applicable> Related #27850
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
**Description:** The linter runs are taking longer and longer as more components and dependencies are added, it's preferable to simply run on each individual component. **Link to tracking Issue:** Related: open-telemetry#27850
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…ry#27884) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Same idea as open-telemetry#27865, remove generated code from being linted. The linter is taking longer and longer to run as more components and dependencies are added. This change is to remove unnecessary modules from being linted, which will help reduce runtime and resources required. **Link to tracking Issue:** <Issue number if applicable> Related open-telemetry#27850
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** The linter runs are taking longer and longer as more components and dependencies are added, it's preferable to simply run on each individual component. **Link to tracking Issue:** Related: open-telemetry#27850
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…ry#27884) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Same idea as open-telemetry#27865, remove generated code from being linted. The linter is taking longer and longer to run as more components and dependencies are added. This change is to remove unnecessary modules from being linted, which will help reduce runtime and resources required. **Link to tracking Issue:** <Issue number if applicable> Related open-telemetry#27850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The linter runs are taking longer and longer as more components and dependencies are added, it's preferable to simply run on each individual component.
Link to tracking Issue:
Related: #27850