feat: add IsDouble function #29076
Merged
feat: add IsDouble function #29076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennep
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
|
Please run |
etiennep
force-pushed
the
etiennep.issue-27895-IsDouble-converter
branch
3 times, most recently
from
70d567d to
372f1e4
Compare
etiennep
force-pushed
the
etiennep.issue-27895-IsDouble-converter
branch
from
372f1e4 to
a546ea3
Compare
TylerHelmuth
reviewed
Nov 9, 2023
etiennep
force-pushed
the
etiennep.issue-27895-IsDouble-converter
branch
from
a546ea3 to
3760866
Compare
atoulme
approved these changes
Nov 10, 2023
etiennep
force-pushed
the
etiennep.issue-27895-IsDouble-converter
branch
4 times, most recently
from
847c497 to
a33c1d5
Compare
TylerHelmuth
approved these changes
Nov 13, 2023
|
@etiennep I merged another function so we need a rebase. |
etiennep
force-pushed
the
etiennep.issue-27895-IsDouble-converter
branch
from
a33c1d5 to
af22f14
Compare
Done! |
TylerHelmuth
added
the
ready to merge
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
**Description:** Adds new a new `IsDouble` function to facilitate type checking. Most useful when checking the type of a body to determine if it needs to be parsed or not. **Link to tracking Issue:** open-telemetry#27895 **Testing:** Added unit test **Documentation:** Updated the func readme. Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
**Description:** Adds new a new `IsDouble` function to facilitate type checking. Most useful when checking the type of a body to determine if it needs to be parsed or not. **Link to tracking Issue:** open-telemetry#27895 **Testing:** Added unit test **Documentation:** Updated the func readme. Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds new a new
IsDoublefunction to facilitate type checking. Most useful when checking the type of a body to determine if it needs to be parsed or not.Link to tracking Issue: #27895
Testing: Added unit test
Documentation: Updated the func readme.