Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Redisreceiver/update redis client version #29600

Conversation

hughesjj
Copy link
Contributor

@hughesjj hughesjj commented Dec 1, 2023

Description:

Link to tracking Issue:

Testing:

Documentation:

@github-actions github-actions bot added the receiver/redis Redis related issues label Dec 1, 2023
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Dec 1, 2023
@hughesjj hughesjj changed the title Redisreceiver/update redis client version [chore] Redisreceiver/update redis client version Dec 1, 2023
@github-actions github-actions bot added the cmd/configschema configschema command label Dec 1, 2023
@hughesjj hughesjj marked this pull request as ready for review December 1, 2023 02:33
@hughesjj hughesjj requested a review from a team December 1, 2023 02:33
@hughesjj hughesjj requested a review from mx-psi as a code owner December 1, 2023 02:33
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLease rebase

component: redisreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Upgrade the redis library dependency to resolve security vulns in v7 (also, we should be tracking v8 anyway)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
note: Upgrade the redis library dependency to resolve security vulns in v7 (also, we should be tracking v8 anyway)
note: Upgrade the redis library dependency to resolve security vulns in v7

@dmitryax
Copy link
Member

dmitryax commented Dec 4, 2023

@hughesjj there is still a conflict. Please rebase on the latest main

repo name

gomod updates

update main go.sum

change invocation to include background context

also add for cmd/otelcontribcol

add chglog

go mod tidy configschema for redis

retidy main

Update .chloggen/redisreceiver_update_redis_client_version.yaml

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>

Update .chloggen/redisreceiver_update_redis_client_version.yaml

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>

Update .chloggen/redisreceiver_update_redis_client_version.yaml

Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>

fix chglog message
@hughesjj hughesjj force-pushed the redisreceiver/update_redis_client_version branch from 76e0cd0 to bd8c441 Compare December 4, 2023 19:42
@dmitryax dmitryax merged commit d30d17f into open-telemetry:main Dec 4, 2023
79 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command receiver/redis Redis related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants