[exporter/logicmonitorexporter] Support log resource mapping config #29733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor-contrib into support-log-resource-mapping-config
github-actions
bot
added
cmd/otelcontribcol
mx-psi
reviewed
Dec 11, 2023
…ctor-contrib into support-log-resource-mapping-config
mx-psi
approved these changes
Dec 12, 2023
mx-psi
added
the
ready to merge
…ctor-contrib into support-log-resource-mapping-config
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…pen-telemetry#29733) **Description:** This PR adds support for resource mapping config for logs. To make the resource mapping for logs flexible, LogicMonitor platform expects some params to be present in the log ingestion request. We have changed the exporter configuration to accept that configuration. **Link to tracking Issue:** open-telemetry#29732 **Testing:** Unit test cases were added. Also did the functional testing for the log ingestion with the newly added config. **Documentation:** As per the LogicMonitor's [Log Ingestion documentation](https://www.logicmonitor.com/support/lm-logs/sending-logs-to-the-lm-logs-ingestion-api), if more than one resource property exists, only the first property will be mapped. In case of OTLP logs, there can be multiple resource attributes and its order also cannot be guaranteed. Recently, the LogicMonitor has made the resource mapping for logs more flexible. With that, any of the resource attributes present in the log matches can be considered for resource mapping. But, this is not the default behaviour. In order to make the resource mapping flexible, you can configure the resource_mapping_op in the LogicMonitor's exporter. ``` exporters: logicmonitor: ... logs: resource_mapping_op: "OR" ``` The value for resource_mapping_op can be AND or OR. The values are case-insensitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for resource mapping config for logs.
To make the resource mapping for logs flexible, LogicMonitor platform expects some params to be present in the log ingestion request. We have changed the exporter configuration to accept that configuration.
Link to tracking Issue: #29732
Testing: Unit test cases were added. Also did the functional testing for the log ingestion with the newly added config.
Documentation:
As per the LogicMonitor's Log Ingestion documentation, if more than one resource property exists, only the first property will be mapped. In case of OTLP logs, there can be multiple resource attributes and its order also cannot be guaranteed.
Recently, the LogicMonitor has made the resource mapping for logs more flexible. With that, any of the resource attributes present in the log matches can be considered for resource mapping. But, this is not the default behaviour. In order to make the resource mapping flexible, you can configure the resource_mapping_op in the LogicMonitor's exporter.
The value for resource_mapping_op can be AND or OR. The values are case-insensitive.