-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the obsolete +build directive #30651
Remove the obsolete +build directive #30651
Conversation
facce1a
to
25a8a8f
Compare
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
semconv "go.opentelemetry.io/collector/semconv/v1.21.0" | ||
"go.uber.org/zap" | ||
|
||
"github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor" | ||
"github.com/open-telemetry/opentelemetry-collector-contrib/cmd/opampsupervisor/supervisor/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure the linter wasn't complaining about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the linter only runs against files which match certain tags. See #11557
Not sure if the new syntax is handled more appropriately but it's possible we have better coverage now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. This change was triggered by my IDE, not linter
"// +build" was replaced with "//go:build" directive in 1.17. +build can be removed since we support only 1.20 and 1.21
8db5c8c
to
900e5ee
Compare
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
`// +build` was replaced with `//go:build` directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21 Same as open-telemetry/opentelemetry-collector#9304
// +build
was replaced with//go:build
directive in Go 1.17. +build can be removed since we support only 1.20 and 1.21Same as open-telemetry/opentelemetry-collector#9304