fix ec2 scraper attribute drop without describeTags #30672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
Aneurysm9
reviewed
Jan 25, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I’ll add tests. |
Aneurysm9
reviewed
Feb 23, 2024
akats7
force-pushed
the
ec2-scraper-update
branch
from
0a35cc3
to
6728a41
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Can we remove the stale label please @Aneurysm9 @dashpole |
Aneurysm9
approved these changes
Apr 1, 2024
|
Hey @evan-bradley, are we able to get this merged |
|
@akats7 Sorry for the delay. It looks like we are having some Go module issues right now, once those are resolved I'll update the branch and merge or ping you if I need you to update anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Minor fix to update ec2 scraper to apply successfully extracted ec2 attributes (instanceId, cloud region, etc..) even when describeTags return an error (likely due to permissions). Currently if tags are not able to be extracted, Detect returns an err and detectResource does not apply the remaining attributes.
Link to tracking Issue: N/A
Testing:
Added tests to test usage of describeTags in detect, made minor modification to detector signature to make it testable.
Documentation: