Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporters/skywalking] Mark as unmaintained #30781

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

jpkrohling
Copy link
Member

Related to #23796, this marks the SkyWalking exporter as deprecated.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping track of this component and documenting the efforts made along the way.

@TylerHelmuth
Copy link
Member

I dont remember how we've done it in the past but maybe a changelog entry telling users "this is deprecated" would be a good idea.

@jpkrohling
Copy link
Member Author

Yeah, I'm adding it, was just too slow :-)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling added the ready to merge Code review completed; ready to merge by maintainers label Jan 26, 2024
@jpkrohling
Copy link
Member Author

jpkrohling commented Jan 26, 2024

Despite this being reviewed by different people, I'd feel more comfortable if another maintainer would merge this.

@evan-bradley evan-bradley merged commit dc18660 into open-telemetry:main Jan 26, 2024
90 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 26, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
Related to open-telemetry#23796, this marks the SkyWalking exporter as deprecated.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

---------

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/skywalking ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants