restructured fileexporter to prepare for group_by #31068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Feb 6, 2024
djaglowski
added
Skip Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In fileexporter: restructured code by splitting out two functionality from
fileExporter: marshalling and compression logic was moved tomarshaller, and logic related to writing to file and buffering writes was moved to,fileWriter.This pr introduces no changes to the behavior. The restructure was made in preparation for adding the new group_by functionality (see linked ticket for more detail).
Link to tracking Issue: #24654
Testing: Tests have been updated for the new structure. No tests were added or modified beyond the structural changes.
Documentation: This pr introduces no user-facing changes.