[chore] reuse struct when parsing to avoid recursive parsing #31727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
requested review from
MovieStoreGuy,
andrzej-stencel,
dashpole,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
Aneurysm9,
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
jsuereth,
arminru,
songy23 and
bryan-aguilar
as code owners
github-actions
bot
added
cmd/configschema
atoulme
removed
exporter/googlecloud
exporter/googlemanagedprometheus
github-actions
bot
added
exporter/datadog
crobert-1
approved these changes
Mar 20, 2024
|
This is good to go now - the PR will accommodate to the deprecation of the component.UnmarshalConfig function. |
mx-psi
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a companion PR to handle recursive state of unmarshalers with open-telemetry/opentelemetry-collector#9750. Changing this behavior will allow the confmap.Conf object to recognize that it has already run the
Unmarshalmethod on the struct, and run the mapstructure decoding of fields.