Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Report otelcol_datadog_otlp_translator_resources_missing_source metric #31805

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 18, 2024

Description:

Adds new telemetry metric, otelcol_datadog_otlp_translator_resources_missing_source, that counts OTLP resources missing a hostname-identifying attribute.

Datadog correlation and infrastructure features may not work correctly or be fully featured if payloads are missing a hostname; this metric is useful to track this.

Internal reference: OTEL-1155

Testing: Tested with the following configuration:

Configuration (Click to expand)
receivers:
  prometheus:
    config:
      scrape_configs:
      - job_name: 'otelcol'
        scrape_interval: 10s
        static_configs:
        - targets: ['0.0.0.0:8888']
        metric_relabel_configs:
          - source_labels: [ __name__ ]
            regex: '.*grpc_io.*'
            action: drop
    
  hostmetrics:
    scrapers:
      load:

exporters:
  datadog:
    api::key: ${env:DD_API_KEY}
  debug:

service:
  pipelines:
    metrics:
      receivers: [prometheus, hostmetrics]
      exporters: [debug, datadog]

Documentation: To be added on Datadog docs

@github-actions github-actions bot added the exporter/datadog Datadog components label Mar 18, 2024
@mx-psi mx-psi force-pushed the mx-psi/OTEL-1155-enable-internal-metric branch from a25e99d to 4a8e298 Compare March 18, 2024 10:17
@mx-psi mx-psi changed the title [exporter/datadog] Report datadog.otlp_translator.resources.missing_source metric [exporter/datadog] Report otelcol_datadog_otlp_translator_resources_missing_source metric Mar 18, 2024
@mx-psi mx-psi marked this pull request as ready for review March 18, 2024 11:33
@mx-psi mx-psi requested a review from a team March 18, 2024 11:33
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Mar 18, 2024
@mx-psi mx-psi merged commit f456758 into open-telemetry:main Mar 18, 2024
149 checks passed
@mx-psi mx-psi deleted the mx-psi/OTEL-1155-enable-internal-metric branch March 18, 2024 19:07
@github-actions github-actions bot added this to the next release milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants