RabbitMQ exporter implementation #32051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swar8080
force-pushed
the
rabbitmq-exporter-implementation
branch
from
04b7cc1
to
d4775b1
Compare
swar8080
changed the title
|
FYI @atoulme this is ready for review (since you're the component sponsor) |
atoulme
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
The code looks good but I didn't test it myself. This can land and we can add a test like this one to make sure no leaks are present in a subsequent PR: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/zipkinreceiver/package_test.go
atoulme
added
the
ready to merge
Conflicts: exporter/rabbitmqexporter/go.mod exporter/rabbitmqexporter/go.sum
|
@swar8080 Could you resolve the conflicts? |
|
@evan-bradley the pipeline passed if you want to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the completed implementation of the rabbitmq exporter.
Link to tracking Issue:
#28891
Testing:
Documentation:
Updated README with more configuration options