[pkg/stanza/operator/transformer/recombine] Add max_unmatched_batch_size to recombine operator #32168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasia-kujawa
changed the title
kasia-kujawa
force-pushed
the
fixed_recombine_add_max_unmatched_batch_size
branch
4 times, most recently
from
1010656 to
2513520
Compare
|
I'm still testing this, I'll let you know when it is ready for review. |
kasia-kujawa
force-pushed
the
fixed_recombine_add_max_unmatched_batch_size
branch
17 times, most recently
from
065619f to
5330811
Compare
|
It is ready for review @djaglowski Random failures of tests were caused by missing initialization of The failure of coverage test doesn't look as related to my changes, it looks like as related to codecov/codecov-action#1359 |
kasia-kujawa
force-pushed
the
fixed_recombine_add_max_unmatched_batch_size
branch
from
5330811 to
547c1df
Compare
|
@sumo-drosiek please take a look also ;) |
andrzej-stencel
approved these changes
Apr 10, 2024
kasia-kujawa
force-pushed
the
fixed_recombine_add_max_unmatched_batch_size
branch
from
547c1df to
d065193
Compare
…ize to recombine operator
…_unmatched_batch_size tests to isolate the root cause of potential problems overwrite_with config option is tested in other test cases
… in tests with is_last_entry where last entry matches regular expression to avoid of time condition in flushing
kasia-kujawa
force-pushed
the
fixed_recombine_add_max_unmatched_batch_size
branch
4 times, most recently
from
ef530d6 to
39e0880
Compare
sumo-drosiek
approved these changes
Apr 11, 2024
…ize - initialize value of matchDetected for new batch fix test cases for max_unmatched_batch_size - some had incorrect expected values
kasia-kujawa
force-pushed
the
fixed_recombine_add_max_unmatched_batch_size
branch
from
39e0880 to
a6bc569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add a new max_unmatched_batch_size config parameter to configure the maximum number of consecutive entries that will be combined into a single entry before the match occurs
Link to tracking Issue: #31653
Testing: unit tests, manual tests
Documentation: Add description of the new config option
Changes from #32144 with improvements in tests