sumologicexporter: refactor sender #32643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 22, 2024 11:08
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
|
Forget to create as draft 😓 |
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
aboguszewski-sumo,
kasia-kujawa,
mat-rumian,
rnishtala-sumo and
swiatekm
added 2 commits
April 24, 2024 07:11
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
commented
Apr 24, 2024
|
Not sure why correctness tests timed out 😕 |
swiatekm
approved these changes
Apr 24, 2024
I didn't get a chance to see the failed action being referenced, but there's an open issue (#27295) for a test that's timing out frequently, most likely unrelated to your changes 👍 |
mx-psi
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor sender in order to prepare for adding OTLP formats
Reduces size of #32315
Reopens #32592 due to revert due to test issues
Link to tracking Issue: #31479
Testing:
Minimal changes to unit tests to ensure that everything works like before
Documentation:
N/A