Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/telemetrygen: Add headers to gRPC metadata for logs #32668

Merged

Conversation

metalmatze
Copy link
Contributor

Description:
So far, sending (HTTP) headers along with gRPC requests hasn't been possible.
For that reason, sending bearer tokens for authentication didn't work either.

This is fixed now.

Updated version of #30082
cc @mx-psi

@metalmatze metalmatze requested a review from a team April 24, 2024 13:53
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Apr 24, 2024
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reopening, LGTM!

@metalmatze metalmatze force-pushed the telemetrygen-logs-grpc-metadata branch from f6308ce to d796638 Compare April 24, 2024 14:05
@metalmatze
Copy link
Contributor Author

Rebased against the latest main. It was quite a bit outdated by now.

@metalmatze metalmatze force-pushed the telemetrygen-logs-grpc-metadata branch from d796638 to f528611 Compare April 24, 2024 15:38
@songy23 songy23 added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Apr 24, 2024
.chloggen/telemetrygen-logs-grpc-metadata.yaml Outdated Show resolved Hide resolved
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@mx-psi mx-psi merged commit d291a32 into open-telemetry:main Apr 25, 2024
171 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 25, 2024
@metalmatze metalmatze deleted the telemetrygen-logs-grpc-metadata branch April 29, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants