Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/followup fix kinesis compression #32860

Conversation

leorinat
Copy link
Contributor

@leorinat leorinat commented May 6, 2024

Description:
Follow up fix on kinesis exporter compression. The streams were not closed properly so the compressed data was not generating compression footers

Testing:

  • tested compressed and uncompressed data locally
  • modified compressor test to validate uncompressed data by content and not just size

…The data is not properly created otherwise

- added data integrity tests by decompressing data and not just checking the size
@MovieStoreGuy MovieStoreGuy added the ready to merge Code review completed; ready to merge by maintainers label May 6, 2024
@MovieStoreGuy MovieStoreGuy merged commit 391429f into open-telemetry:main May 7, 2024
167 checks passed
@github-actions github-actions bot added this to the next release milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/awskinesis ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants