[receiver/kubeletstats] Add k8s.pod.cpu.node.utilization metric #33390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
add_k8s_pod_utilization
branch
4 times, most recently
from
0829cbb to
49f4e75
Compare
andrzej-stencel
approved these changes
Jun 5, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
add_k8s_pod_utilization
branch
from
49f4e75 to
9e43537
Compare
tiffany76
reviewed
Jun 11, 2024
Co-authored-by: Tiffany Hrabusa <30397949+tiffany76@users.noreply.github.com>
TylerHelmuth
approved these changes
Jun 12, 2024
andrzej-stencel
pushed a commit
that referenced
this pull request
Jul 10, 2024
…ion` metrics (#33591) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Similar to #32295 and #33390, this PR adds the `k8s.{container,pod}.memory.node.utilization` metrics. **Link to tracking Issue:** <Issue number if applicable> #27885 **Testing:** <Describe what testing was performed and which tests were added.> Added unit test. **Documentation:** <Describe the documentation added.> Added ### Manual testing 1. Using the following target Pod: ```yaml apiVersion: v1 kind: Pod metadata: name: memory-demo spec: containers: - name: memory-demo-ctr image: polinux/stress resources: requests: memory: "8070591Ki" limits: memory: "9070591Ki" command: ["stress"] args: ["--vm", "1", "--vm-bytes", "800M", "--vm-hang", "4"] ``` 2.  On a node of 32,5G memory the 800Mb container/Pod consumes the `0.8/32.5=0.0246...=0.025`. --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
k8s.pod.cpu.node.utilizationmetric.Follow up from #32295 (comment) (cc @TylerHelmuth) .
Link to tracking Issue:
Related to #27885.
Testing: Adjusted the respective unit test to cover this metric as well.
Documentation: Added
Tested with a single container Pod: