Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update gqlparser indirect dependency to v2.5.16 to fix graphql generation #33552

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented Jun 13, 2024

This is a byproduct of this issue posted in the Genqlient repository of the gqlparser dependency being updated. This was patched in an updated version v2.5.16

Description:
Upgraded indirect dependency to take in patch fixing workflow errors.

Link to tracking Issue:
#33551

This is a byproduct of [this issue](Khan/genqlient#340)
posted in the Genqlient repository of the gqlparser dependency being
updated. This was patched in an updated version v2.5.16
@adrielp adrielp requested a review from andrzej-stencel as a code owner June 13, 2024 15:48
@adrielp adrielp requested a review from a team June 13, 2024 15:48
@adrielp adrielp changed the title [chore] update go.mod and go.sum files to fix broken workflows [chore] update gqlparser indirect dependency to v2.5.16 to fix graphql generation Jun 13, 2024
@crobert-1
Copy link
Member

go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this so quickly!

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jun 13, 2024
@crobert-1
Copy link
Member

The failing action build-and-test / correctness-traces is frequency of #27295.

@evan-bradley evan-bradley merged commit 1b172e7 into open-telemetry:main Jun 13, 2024
161 checks passed
@evan-bradley
Copy link
Contributor

Thanks @adrielp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/tools ready to merge Code review completed; ready to merge by maintainers receiver/gitprovider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants