[receiver/vcenter] Fixes multiple datacenters issue #33735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
StefanKurek
force-pushed
the
fix/vcenter-multiple-datacenters
branch
2 times, most recently
from
5d5a85c
to
f2e71fb
Compare
crobert-1
reviewed
Jun 27, 2024
StefanKurek
force-pushed
the
fix/vcenter-multiple-datacenters
branch
from
588a3cc
to
f5f74ae
Compare
crobert-1
approved these changes
Jun 28, 2024
| component: vcenterreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Fixes errors when multiple datacenters in some of the client calls. |
There was a problem hiding this comment.
Suggested change
| note: Fixes errors when multiple datacenters in some of the client calls. | |
| note: Fixes errors in some of the client calls for environments containing multiple datacenters. |
Minor wording nit, the current wording of when multiple datacenters is unclear (at least to me).
receiver/vcenterreceiver/scraper.go
Outdated
| @@ -128,13 +130,30 @@ func (v *vcenterMetricScraper) scrapeAndProcessAllMetrics(ctx context.Context, e | |||
| return errs.Combine() | |||
| } | |||
|
|
|||
| // scrapeDatacenterInventoryListObjects scrapes and store all Datacenter objects with their InventoryLists | |||
There was a problem hiding this comment.
Suggested change
| // scrapeDatacenterInventoryListObjects scrapes and store all Datacenter objects with their InventoryLists | |
| // scrapeDatacenterInventoryListObjects scrapes and stores all Datacenter objects with their InventoryLists |
StefanKurek
force-pushed
the
fix/vcenter-multiple-datacenters
branch
from
0980475
to
e2b7278
Compare
djaglowski
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes issue with client when there are multiple datacenters. Now first all datacenters (object type) will be collected. They will be passed into the problematic client methods. These methods will now set each datacenter in the list individually as the internal client finds the relevant objects and adds to a master list.
Link to tracking Issue:
#33734
Testing:
Unit test tweaked to find issue. Failure noted. Then passing after fix was added.
Documentation:
None needed.