-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/vcenter] Adds additional resource pool metrics #33741
[receiver/vcenter] Adds additional resource pool metrics #33741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes. Otherwise looks good.
8ec60a9
to
5bc7964
Compare
e97a851
to
242f54a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason these are separate metrics, instead of a single metric with an attribute to differentiate the data points?
In other words, are these mutually exclusive sections of memory that can be added together to represent a useful total?
Can we use well defined attributes such as system.memory.state
?
The metrics are not mutually exclusive sections of memory. Summing the different metrics together wouldn't give you any meaningful total. |
I don't understand the relationship between these metrics but I am skeptical that we need four metrics with the same model to describe memory. Can you link documentation for them? |
Yeah, heres a link for those metrics |
Based on the descriptions is unclear to me why |
I'd be alright combining these three metrics and keeping the ballooned separate. |
@djaglowski I believe all the memory metrics in question are coming from here. Also, we do have precedent for the ballooned and swapped memory metrics already exist for VMs. Private and shared memory could possibly be combined into a single metric with an attribute differentiating them. I'm not sure what a good metric name would be though. |
0bbc87d
to
14c2496
Compare
83837e3
to
27a69e1
Compare
27a69e1
to
76d64dc
Compare
ce64e5b
to
cd99c08
Compare
Description:
The following PR adds these metrics
It also adds the attribute
memory_usage_type
and splits up thevcenter.resource_pool.memory.usage
metric into the following attributes:host, guest, overhead
Link to tracking Issue: #33607
Testing:
Golden files were generated to show the addition of the new metrics.
Documentation:
Documentation generated by
make generate
.