[receiver/vcenter] Adds vCenter VSAN Host metrics #34063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
suggested changes
Jul 15, 2024
StefanKurek
reviewed
Jul 16, 2024
StefanKurek
reviewed
Jul 16, 2024
StefanKurek
reviewed
Jul 16, 2024
StefanKurek
suggested changes
Jul 16, 2024
receiver/vcenterreceiver/testdata/metrics/expected-all-enabled.yaml
Outdated
Show resolved
Hide resolved
StefanKurek
approved these changes
Jul 17, 2024
StefanKurek
force-pushed
the
feat/add-vsan-host-metrics
branch
from
b92c3eb to
448f852
Compare
StefanKurek
force-pushed
the
feat/add-vsan-host-metrics
branch
from
448f852 to
8aa554b
Compare
remove golden.write refactor client.go, introduce more abstraction, reduce duplication Cleaned up client.go, use metric.interval for metrics collection added changelog, removed clusterRefs update int to float on congestion, update error handling calls
StefanKurek
force-pushed
the
feat/add-vsan-host-metrics
branch
from
8aa554b to
490d016
Compare
djaglowski
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The following PR adds VSAN host metric collection. The following metrics are collected
Link to tracking Issue: #33556
Testing:
Added mock data fields in order to test vsan host metric scraping. Updated golden test file output.
Documentation:
Updated documentation using
make generate