Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loadbalancer] Add a new routing key: streamID #34086

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

RichieSams
Copy link
Contributor

@RichieSams RichieSams commented Jul 16, 2024

Description: This adds a new routing option for metrics: streamID. This routes datapoints based on their streamID. That's the unique hash of all it's attributes, plus the attributes and identifying information of its resource, scope, and metric data

Link to tracking Issue: #32513

Testing: I added to the existing testing suites, testing the new routing, as well as adding to the benchmark suite

Documentation: I updated the README to describe the new routingKey: metricID, and how it works

Which routes based on the unique identifier of a specific datapoint
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm eager to see real-world feedback about this, especially regarding performance considerations. Given that this change is not impacting current users, I'm merging this.

@jpkrohling jpkrohling merged commit 12d071d into open-telemetry:main Jul 16, 2024
155 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants