[exporter/kafkaexporter] Add encoding extensions support #34384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmshmm
force-pushed
the
feature/kafkaexporter-enc-ext
branch
from
cefd004 to
4fc8e6e
Compare
atoulme
approved these changes
Aug 1, 2024
thmshmm
force-pushed
the
feature/kafkaexporter-enc-ext
branch
2 times, most recently
from
5ef1de6 to
6caca3e
Compare
|
@MovieStoreGuy can you please review? |
thmshmm
force-pushed
the
feature/kafkaexporter-enc-ext
branch
2 times, most recently
from
07c1a1d to
eca44da
Compare
|
Hey @thmshmm, Do you mind doing the same again here where it failsover to the local encodings if there is no encoding extension defined? |
thmshmm
force-pushed
the
feature/kafkaexporter-enc-ext
branch
from
eca44da to
4385cac
Compare
MovieStoreGuy
approved these changes
Sep 11, 2024
thmshmm
force-pushed
the
feature/kafkaexporter-enc-ext
branch
from
eecdaf3 to
4646725
Compare
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…try#34384) **Description:** Add support for encoding extensions in the kafkaexporter To be able to use encoding extensions this PR adds extension support and proposes to rename the existing `encoding` configuration property to `format` and reusing the `encoding` property for configuring encoding extensions. Reason is to be consistent with other receivers/exporters. Related to open-telemetry#33888 which adds encoding extension support in the `kafkareceiver`. **Link to tracking Issue:** n/a **Testing:** Tested via the following configuration. ``` receivers: kafka: brokers: - localhost:29092 encoding: json group_id: test1 topic: logs_in extensions: json_log_encoding: exporters: debug: verbosity: detailed kafka: brokers: - localhost:29092 encoding: json_log_encoding topic: json_out processors: batch: service: extensions: [json_log_encoding] pipelines: logs: receivers: [kafka] processors: [batch] exporters: [debug, kafka] telemetry: logs: level: "info" ``` Any json can be written to the `logs_in` topic and results be viewed in the `json_out` topic. When removing `encoding: json_log_encoding` the default format type is used and the output in `json_out` topic changes accordingly. **Documentation:** Updated README.md within the receiver describing the use of encoding extensions. Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add support for encoding extensions in the kafkaexporter
To be able to use encoding extensions this PR adds extension support and proposes to rename the existing
encodingconfiguration property toformatand reusing theencodingproperty for configuring encoding extensions. Reason is to be consistent with other receivers/exporters.Related to #33888 which adds encoding extension support in the
kafkareceiver.Link to tracking Issue: n/a
Testing: Tested via the following configuration.
Any json can be written to the
logs_intopic and results be viewed in thejson_outtopic.When removing
encoding: json_log_encodingthe default format type is used and the output injson_outtopic changes accordingly.Documentation: Updated README.md within the receiver describing the use of encoding extensions.