Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix failing test on windows #34722

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[chore] Fix failing test on windows #34722

merged 1 commit into from
Aug 16, 2024

Conversation

djaglowski
Copy link
Member

This test is failing here based on different wording in the error message.

@djaglowski djaglowski added the Run Windows Enable running windows test on a PR label Aug 16, 2024
@djaglowski djaglowski marked this pull request as ready for review August 16, 2024 17:27
@djaglowski djaglowski requested a review from a team August 16, 2024 17:27
songy23
songy23 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @pjanotti

codeboten
codeboten approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codeboten codeboten merged commit 16154e0 into open-telemetry:main Aug 16, 2024
179 of 180 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 16, 2024
@songy23 songy23 mentioned this pull request Aug 16, 2024
Closed
@djaglowski djaglowski deleted the rabbitmq-win-fix branch August 16, 2024 18:34
frzifus
frzifus reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
@djaglowski @f7o
[chore] Fix failing test on windows (open-telemetry#34722)
33b3896 
This test is failing
[here](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10422926675/job/28869517481?pr=34720#step:6:468)
based on different wording in the error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frzifus frzifus frzifus left review comments

@codeboten codeboten codeboten approved these changes

@songy23 songy23 songy23 approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

Assignees

@codeboten codeboten

Labels
internal/rabbitmq Run Windows Enable running windows test on a PR
Projects
None yet
Milestone
v0.108.0
Development

Successfully merging this pull request may close these issues.
4 participants
@djaglowski @codeboten @frzifus @songy23