Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/tailsampling]: Enable inverse filtering for boolean attribute filter #34730

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

bacherfl
Copy link
Contributor

Description: This PR adds the invert_match option for boolean_attribute filters, as discussed in #34296 (comment)

Link to tracking Issue: #34296

Testing: Added unit tests

Documentation: The existing documentation already covered the semantics of the invert_match option

…ute filter

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label Aug 19, 2024
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@bacherfl bacherfl marked this pull request as ready for review August 20, 2024 04:58
@bacherfl bacherfl requested a review from a team August 20, 2024 04:58
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 3, 2024
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks OK, but can you add a documentation to the readme? It would also be nice to have a concrete use case listed there.

@github-actions github-actions bot removed the Stale label Sep 7, 2024
@bacherfl
Copy link
Contributor Author

The change itself looks OK, but can you add a documentation to the readme? It would also be nice to have a concrete use case listed there.

sure, will add docs for this today

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@jpkrohling jpkrohling merged commit a60ad92 into open-telemetry:main Sep 18, 2024
155 of 156 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 18, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…ute filter (open-telemetry#34730)

**Description:** This PR adds the `invert_match` option for
`boolean_attribute` filters, as discussed in
open-telemetry#34296 (comment)

**Link to tracking Issue:** open-telemetry#34296

**Testing:** Added unit tests

**Documentation:** The existing documentation already covered the
semantics of the `invert_match` option

---------

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/tailsampling Tail sampling processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants