[receiver/sqlserver] Emit correct database name resource attribute #35038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Sep 5, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…pen-telemetry#35038) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> As explained in the bug description, the receiver was incorrectly setting the database name resource attribute based on the first row returned from the query. The returned rows may have different database names, which means metrics were being labeled as being from the wrong database. **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#35036 **Testing:** <Describe what testing was performed and which tests were added.> Updated tests for new expected resource metrics. View changed `testdata/` files to see changed output.
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…pen-telemetry#35038) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> As explained in the bug description, the receiver was incorrectly setting the database name resource attribute based on the first row returned from the query. The returned rows may have different database names, which means metrics were being labeled as being from the wrong database. **Link to tracking Issue:** <Issue number if applicable> Fixes open-telemetry#35036 **Testing:** <Describe what testing was performed and which tests were added.> Updated tests for new expected resource metrics. View changed `testdata/` files to see changed output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As explained in the bug description, the receiver was incorrectly setting the database name resource attribute based on the first row returned from the query. The returned rows may have different database names, which means metrics were being labeled as being from the wrong database.
Link to tracking Issue:
Fixes #35036
Testing:
Updated tests for new expected resource metrics. View changed
testdata/files to see changed output.