Allow indexing string slice type #35581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkwronski
requested review from
TylerHelmuth,
bogdandrutu,
evan-bradley and
a team
as code owners
lkwronski
force-pushed
the
lkwronski.issue-29441-slice
branch
from
f4881d7 to
0542dad
Compare
TylerHelmuth
approved these changes
Oct 7, 2024
evan-bradley
approved these changes
Oct 14, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
**Description:** Allow indexing string slice type. I can also add support for other types such as []int if needed. Let me know if this approach is good enough. I haven't found a more generic solution, thank you for any feedback. **Link to tracking Issue:** Fixes open-telemetry#29441 **Testing:** Unit test **Documentation:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Allow indexing string slice type. I can also add support for other types such as []int if needed. Let me know if this approach is good enough.
I haven't found a more generic solution, thank you for any feedback.
Link to tracking Issue: Fixes #29441
Testing: Unit test
Documentation: