-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added prometheus rw2 translation for gauges #35734
feat: added prometheus rw2 translation for gauges #35734
Conversation
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
The PR is basically ready for merge to be honest, I just have a few questions and comments around tests
pkg/translator/prometheusremotewrite/number_data_points_v2_test.go
Outdated
Show resolved
Hide resolved
pkg/translator/prometheusremotewrite/number_data_points_v2_test.go
Outdated
Show resolved
Hide resolved
…t.go Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after outstanding comment is resolved
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Follow up from open-telemetry#35703. Draft starting the work on adding support for remote write 2.0 in the translation package. Adding support for translating gauges. This is first iteration and to keep the PR small * we don't handle duplicate metrics * only support gauges * don't handle other labels than metric name * don't handle exemplars * don't handle metadata <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry#33661 Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com> Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: David Ashpole <dashpole@google.com>
Description
Follow up from #35703.
Draft starting the work on adding support for remote write 2.0 in the translation package.
Adding support for translating gauges.
This is first iteration and to keep the PR small
Link to tracking issue #33661
Fixes
Testing
Documentation