Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added prometheus rw2 translation for gauges #35734

Conversation

jmichalek132
Copy link
Contributor

Description

Follow up from #35703.

Draft starting the work on adding support for remote write 2.0 in the translation package.
Adding support for translating gauges.

This is first iteration and to keep the PR small

  • we don't handle duplicate metrics
  • only support gauges
  • don't handle other labels than metric name
  • don't handle exemplars
  • don't handle metadata

Link to tracking issue #33661

Fixes

Testing

Documentation

Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

The PR is basically ready for merge to be honest, I just have a few questions and comments around tests

jmichalek132 and others added 3 commits October 11, 2024 10:07
…t.go

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after outstanding comment is resolved

Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Oct 11, 2024
@jmichalek132 jmichalek132 changed the title feat: added translation rw2 translation for gauges feat: added prometheus rw2 translation for gauges Oct 13, 2024
@dashpole dashpole added the enhancement New feature or request label Oct 14, 2024
@andrzej-stencel andrzej-stencel merged commit 230ed5c into open-telemetry:main Oct 16, 2024
168 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 16, 2024
@jmichalek132 jmichalek132 deleted the jm-prom-translation-rw2-gauges-support-fixed branch October 16, 2024 17:00
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Follow up from open-telemetry#35703.

Draft starting the work on adding support for remote write 2.0 in the
translation package.
Adding support for translating gauges.

This is first iteration and to keep the PR small
* we don't handle duplicate metrics
* only support gauges
* don't handle other labels than metric name
* don't handle exemplars
*  don't handle metadata

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue open-telemetry#33661
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Juraj Michalek <juraj.michalek132@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Co-authored-by: David Ashpole <dashpole@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg/translator/prometheus ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants