[connector/routing] Add ability to route logs by request context #36067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
djaglowski
force-pushed
the
routing-connector-by-request
branch
4 times, most recently
from
7d4b084 to
9a8856a
Compare
djaglowski
force-pushed
the
routing-connector-by-request
branch
from
9a8856a to
624ea27
Compare
mwear
approved these changes
Oct 30, 2024
ArthurSens
pushed a commit
to ArthurSens/opentelemetry-collector-contrib
that referenced
this pull request
Nov 4, 2024
…n-telemetry#36067) This PR adds the ability to route logs based on request context. Specifically, [values from an incoming context](https://github.com/grpc/grpc-go/blob/v1.67.1/metadata/metadata.go#L216) as defined in `google.golang.org/grpc/metadata` and [client metadata](https://pkg.go.dev/go.opentelemetry.io/collector/client#Metadata) values as defined in `go.opentelemetry.io/collector/client`. Request based routing is implemented as a feature of an individual route. This allows mixing of contexts within a table, so that e.g. you can route low severity logs to one route, route some logs based on resource, and then route the remainder based on request metadata. Notably, when request metadata is matched, this indicates a match for the entire `plog.Logs`, so all remaining data in that structure (i.e. data that hasn't already matched a previous route) will be routed immediately.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…n-telemetry#36067) This PR adds the ability to route logs based on request context. Specifically, [values from an incoming context](https://github.com/grpc/grpc-go/blob/v1.67.1/metadata/metadata.go#L216) as defined in `google.golang.org/grpc/metadata` and [client metadata](https://pkg.go.dev/go.opentelemetry.io/collector/client#Metadata) values as defined in `go.opentelemetry.io/collector/client`. Request based routing is implemented as a feature of an individual route. This allows mixing of contexts within a table, so that e.g. you can route low severity logs to one route, route some logs based on resource, and then route the remainder based on request metadata. Notably, when request metadata is matched, this indicates a match for the entire `plog.Logs`, so all remaining data in that structure (i.e. data that hasn't already matched a previous route) will be routed immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to route logs based on request context. Specifically, values from an incoming context as defined in
google.golang.org/grpc/metadataand client metadata values as defined ingo.opentelemetry.io/collector/client.Request based routing is implemented as a feature of an individual route. This allows mixing of contexts within a table, so that e.g. you can route low severity logs to one route, route some logs based on resource, and then route the remainder based on request metadata. Notably, when request metadata is matched, this indicates a match for the entire
plog.Logs, so all remaining data in that structure (i.e. data that hasn't already matched a previous route) will be routed immediately.