[chore][pkg/stanza/fileconsumer] Emit logs in batches #36276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
changed the title
…ch entry still Next step is to change the emit function to accept a batch.
But still send each entry one by one to the next consumer in the file input. Next step is to change Stanza operators to accept batches.
The File input's `emitBatch` function now calls `ProcessBatch` instead of `Process`. The added `ProcessBatch` method will make each Stanza operator capable of accepting a batch of entries.
This changes the Log Emitter to run the `consumerFunc` on the whole batch, instead of splitting the batch into individual entries and calling `consumerFunc` on each of them. This doesn't change much while the Log Emitter has its own `batch` buffer, but if we remove the `batch` buffer (see open-telemetry#35456), this should prevent the performance drop described in open-telemetry#35454.
andrzej-stencel
force-pushed
the
emit-multiple
branch
from
8e3197b to
0d51650
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Superseded by #36663. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the File consumer to emit logs in batches as opposed to sending each log individually through the Stanza pipeline and on to the Log Emitter.
This was achieved via the following incremental changes, with the goal of making code reviews easier (multiple smaller changesets):
Reader::ReadToEndmethod in File consumer, but still callemitfunction for each token individuallyemit.Callbackfunction signature to accept a slice of tokens and emit tokens in batches from theReader. At this point, the batches are still split into individual tokens inside theemitfunction, because the Stanza operators can only process one entry at a time.ProcessBatchmethod to Stanza operators and use it in theemitfunction. At this point, the batch of tokens is translated to a batch of entries and passed to Log Emitter as a whole. The batch is still split in the Log Emitter, which callsconsumeFuncfor each entry in a loop.consumeFuncon the whole batch of entriesNote that this is currently a draft, requesting initial feedback. I haven't yet implemented the
ProcessBatchmethod for all Stanza operators, as I'd like to first get feedback its definition. Specifically, should the function accept a[]entry.Entryor[]*entry.Entry?Link to tracking issue
Testing
No changes in tests. The goal is for the functionality to not change and for performance to not decrease.
Documentation
These are internal changes, no user documentation needs changing.