Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename k8processor #5384

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

codeboten
Copy link
Contributor

Description:

  • Rename k8sprocessor -> k8sattributesprocessor
  • Update configuration from k8s_tagger -> k8sattributes

Link to tracking Issue: Fixes #5383

Testing: Updated tests accordingly.

Documentation: Updated documentation accordingly.

@codeboten codeboten requested a review from a team September 22, 2021 17:17
@codeboten codeboten changed the title Codeboten/rename k8stagger rename k8processor Sep 22, 2021
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Sep 22, 2021
@bogdandrutu bogdandrutu merged commit de9b30f into open-telemetry:main Sep 23, 2021
@codeboten codeboten deleted the codeboten/rename-k8stagger branch September 23, 2021 15:49
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
…y#5384)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename k8s_tagger configuration to k8sattributes
5 participants