-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus to latest #7115
Conversation
422a931
to
74e2c35
Compare
@Aneurysm9, would you mind taking a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a note, this does not enable the new "extra scrape metrics": https://prometheus.io/docs/prometheus/latest/feature_flags/#extra-scrape-metrics, which could be done via scrape.Options{}
in metrics_receiver.go.
@gouthamve, could you take a look at the CI failures? |
This requires updates to the What about the |
Please run |
ebd2d4d
to
60a95ac
Compare
Unfortunately, there are go.mod conflicts. Once they are fixed, I'll re-run the tests and merge on green. |
60a95ac
to
2a88c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it needs one more make gotidy
go test -race -v -timeout 300s --tags="" ./...
go: updates to go.mod needed; to update it:
go mod tidy
Head branch was pushed to by a user without write access
This updates the Prometheus dependency to the latest version This allows us to import some exporters as libraries into my own projects. Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Tests fail because of new check introduced by Prometheus: https://github.com/prometheus/prometheus/blob/a56f2856ed91edbc2b12e02d8202d7f6620060ad/config/config.go#L288-L290 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
8829404
to
a0d5c91
Compare
This updates the Prometheus dependency to the latest version
This allows us to import some exporters as libraries into my own projects.
Closes #7162
Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com