Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump limits on performance tests #9105

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Apr 6, 2022

Resolves #9094
Resolves #9020 (cpu aspect)

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 6, 2022
@TylerHelmuth
Copy link
Member

I've noticed some builds failing for CPU as well. What do you think about increasing those as well?

@djaglowski djaglowski changed the title Bump limits on log performance tests Bump limits on performance tests Apr 7, 2022
@djaglowski
Copy link
Member Author

I've additionally bumped CPU for a couple metric tests that failed, but I haven't seen CPU failures on the log tests recently. I tend to think we should find an alternate approach to benchmark validation, but I don't want to diverge too much from our previous strategy until another one is identified.

@djaglowski djaglowski marked this pull request as ready for review April 7, 2022 13:05
@djaglowski djaglowski requested review from a team and Aneurysm9 April 7, 2022 13:05
@jpkrohling jpkrohling merged commit 955c2af into open-telemetry:main Apr 7, 2022
@djaglowski djaglowski deleted the bump-log-perf-limits branch April 7, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test - load-test (TestLog10kDPS) [testbed] Flaky Test - MetricsFromFile
4 participants