Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/fluentforward] Release port on shutdown #9111

Merged
merged 6 commits into from
Apr 18, 2022
Merged

[receiver/fluentforward] Release port on shutdown #9111

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a45ce68
Fix for #9110
gagansingh355 Apr 7, 2022
3fa75c1
CHANGELOG.md update
gagansingh355 Apr 7, 2022
389f696
Merge branch 'main' into Fluentforward-receiver-not-listen-port-#9110
gagansingh355 Apr 13, 2022
148b8c4
Merge branch 'main' into Fluentforward-receiver-not-listen-port-#9110
gagansingh355 Apr 14, 2022
2c9c5f6
CHANGELOG.md update
gagansingh355 Apr 14, 2022
9be19f7
Merge branch 'main' into Fluentforward-receiver-not-listen-port-#9110
gagansingh355 Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
- `signalfxexporter`: Fix bug to enable timeouts for correlating traces and metrics (#9101)
- `windowsperfcountersreceiver`: fix exported values being integers instead of doubles (#9138)
- `prometheusreceiver`: Fix issues with relabelling the `job` and `instance` labels. (#8780)
- `fluentforwardreceiver`: Fluentforward receiver not releasing port for reloading of OTEL collector (#9111)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for one more change about this, but we just had a release and this has to be moved to the unreleased section. I tried updating this PR, but I couldn't push my changes.

Copy link
Contributor Author

@gagansingh355 gagansingh355 Apr 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpkrohling I have update this push to unreleased section.


## v0.48.0

Expand Down
1 change: 1 addition & 0 deletions receiver/fluentforwardreceiver/receiver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func (r *fluentReceiver) Start(ctx context.Context, _ component.Host) error {
}

func (r *fluentReceiver) Shutdown(context.Context) error {
r.listener.Close()
r.cancel()
return nil
}