Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky prometheusexporter.TestEndToEndSummarySupport #9244

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix flaky prometheusexporter.TestEndToEndSummarySupport #9244

merged 1 commit into from
Apr 13, 2022

Conversation

gouthamve
Copy link
Member

Fixes #8365

See: #8365 (comment)

@gouthamve
Fix flaky prometheusexporter.TestEndToEndSummarySupport
488c1d0 
Fixes open-telemetry#8365

See: open-telemetry#8365 (comment)

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@gouthamve gouthamve requested a review from a team April 13, 2022 02:04
@gouthamve gouthamve requested a review from Aneurysm9 as a code owner April 13, 2022 02:04
pmm-sumo
pmm-sumo approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The proposal in the comment was 100ms. Will 50ms be enough?

@gouthamve
Copy link
Member Author

Sorry, I think so. The timeout right now is 2ms and bumping it to 50ms is good enough imo. I've tested this by running it with -count=200 and never timed out once (before it was frequent).

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 13, 2022
@jpkrohling jpkrohling merged commit 0328a79 into open-telemetry:main Apr 13, 2022
@gouthamve gouthamve deleted the fix-flaky-test branch April 13, 2022 13:59
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
@gouthamve gouthamve mentioned this pull request Jun 21, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@pmm-sumo pmm-sumo

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky Test - prometheusexporter.TestEndToEndSummarySupport
3 participants
@gouthamve @pmm-sumo @jpkrohling