Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jaegerremotesampling extension to contrib #204

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add jaegerremotesampling extension to contrib #204

merged 1 commit into from
Oct 10, 2022

Conversation

greut
Copy link
Contributor

@greut greut commented Sep 29, 2022

the remote sampling has been removed from the receiver but its replacement wasn't added to the extensions, cf open-telemetry/opentelemetry-collector-contrib#6510

So here it is.

Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
@greut greut requested review from a team and bogdandrutu September 29, 2022 09:45
@jpkrohling jpkrohling requested a review from frzifus September 29, 2022 12:09
@jpkrohling
Copy link
Member

@frzifus, can you review this one?

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that makes sense, thank you @greut!

@jpkrohling jpkrohling merged commit 9bbae65 into open-telemetry:main Oct 10, 2022
@greut greut deleted the fix/add-jaegerremotesampling-extension branch October 10, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants