Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the s3 provider to the contrib distro #546

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evan-bradley
Copy link
Contributor

The s3 provider has not had any major changes for at least a year now, I think it should likely be safe to include it in the contrib distribution.

@Aneurysm9 as the codeowner, please block this if you think this component is not ready for wider use.

@evan-bradley evan-bradley requested review from a team and MovieStoreGuy May 7, 2024 18:13
mx-psi
mx-psi previously requested changes May 7, 2024
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add it to contrib's test build before adding it here

@evan-bradley
Copy link
Contributor Author

I think we should add it to contrib's test build before adding it here

Agreed, I have this PR open to do that: open-telemetry/opentelemetry-collector-contrib#32916. Probably should have included that in the PR description, sorry.

I'd like to have that merged before we merge this, but I would like to at least start the discussion of what prerequisites we'd like when including these in our distributions.

@evan-bradley evan-bradley marked this pull request as draft May 7, 2024 18:27
@evan-bradley
Copy link
Contributor Author

I'll convert this to a draft while open-telemetry/opentelemetry-collector-contrib#32916 is in progress, and until we have consensus.

@atoulme
Copy link
Contributor

atoulme commented May 7, 2024

Happy to review once we have open-telemetry/opentelemetry-collector-contrib#32916 merged. Excited for those changes!

@atoulme
Copy link
Contributor

atoulme commented Jun 4, 2024

Please update the versions and we can get this in.

@evan-bradley
Copy link
Contributor Author

Thanks for the reminder, I got diverted and lost track of this one; sorry for the lack of an update

My plan before marking this as ready was to promote the provider to alpha, but in order to do that, mdatagen needs to support providers. We could look at accelerating the timeline there if you would like, otherwise I was going to pick that back up after I wrap up some other work.

@eduardoasantana
Copy link

Has there been any movement on this?

@mx-psi mx-psi dismissed their stale review August 21, 2024 08:49

contrib's PR got merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants