Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logdedup processor to contrib #633

Closed

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Aug 9, 2024

This processor has been marked as alpha in open-telemetry/opentelemetry-collector-contrib@4ddd4e9

Pinging release manager for v0.107.0 @dmitryax please merge this change once the contrib v0.107.0 modules are tagged

This processor has been marked as alpha in open-telemetry/opentelemetry-collector-contrib@4ddd4e9

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and TylerHelmuth August 9, 2024 18:50
@MikeGoldsmith
Copy link
Member

Fingered crossed this can get into the next contrib release 🤞🏻

@TylerHelmuth
Copy link
Member

@codeboten the k8s distro could take this component as well since it is a vendor-neutral processor.

@arminru arminru requested a review from dmitryax August 13, 2024 08:46
@codeboten
Copy link
Contributor Author

@codeboten the k8s distro could take this component as well since it is a vendor-neutral processor.

Added it as a suggestion in #636

@@ -97,6 +97,7 @@ processors:
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbyattrsprocessor v0.106.1
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/groupbytraceprocessor v0.106.1
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sattributesprocessor v0.106.1
- gomod: github.com/open-telemetry/opentelemetry-collector-contrib/processor/logdedupprocessor v0.106.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it did not exist in this version yet as it was only introduced with open-telemetry/opentelemetry-collector-contrib@b92eb43 and is first released with v0.107.0, so in this version the build won't pass.

Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was merged in #636

@codeboten codeboten closed this Aug 13, 2024
@codeboten codeboten deleted the codeboten/add-log-dedup branch August 13, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants