Fix colerrs pointers/err checks

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
open-telemetry · May 29, 2023 · 4024e2f · 4024e2f
1 parent c51fe00
commit 4024e2f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/internal/colerrs/request.go b/internal/colerrs/request.go
@@ -19,14 +19,14 @@ func NewRequestError(statusCode int, wrapped error) *RequestError {
 	}
 }
 
-func (r *RequestError) Error() string {
+func (r RequestError) Error() string {
 	return r.wrapped.Error()
 }
 
-func (r *RequestError) Unwrap() error {
+func (r RequestError) Unwrap() error {
 	return r.wrapped
 }
 
-func (r *RequestError) StatusCode() int {
+func (r RequestError) StatusCode() int {
 	return r.statusCode
 }
diff --git a/receiver/otlpreceiver/otlphttp.go b/receiver/otlpreceiver/otlphttp.go
@@ -46,8 +46,9 @@ func handleTraces(resp http.ResponseWriter, req *http.Request, tracesReceiver *t
 		}
 
 		// perhaps it was an HTTP exporter that failed?
-		if errors.As(err, &colerrs.RequestError{}) {
-			httpStatus = err.(*colerrs.RequestError).StatusCode()
+		reqErr := &colerrs.RequestError{}
+		if errors.As(err, reqErr) {
+			httpStatus = reqErr.StatusCode()
 		}
 
 		writeError(resp, encoder, err, httpStatus)