Skip to content

Commit

Permalink
Fix TestGenerateAndCompileDefault on windows
Browse files Browse the repository at this point in the history
Fixes #5403

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
bogdandrutu committed Jun 3, 2022
1 parent 8ed9e43 commit 542c441
Showing 1 changed file with 7 additions and 14 deletions.
21 changes: 7 additions & 14 deletions cmd/builder/internal/builder/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,8 @@
package builder

import (
"io/ioutil"
"log"
"os"
"runtime"
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Expand All @@ -45,20 +42,16 @@ func TestGenerateInvalidOutputPath(t *testing.T) {
}

func TestGenerateAndCompileDefault(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("skipping the test on Windows, see https://github.com/open-telemetry/opentelemetry-collector/issues/5403")
}
dir, err := ioutil.TempDir("", "default")
if err != nil {
log.Fatal(err)
}
defer os.RemoveAll(dir)
cfg := NewDefaultConfig()
cfg.Distribution.OutputPath = dir
cfg.Distribution.OutputPath = t.TempDir()

// we override this version, otherwise this would break during releases
cfg.Distribution.OtelColVersion = "0.38.0"
cfg.Distribution.OtelColVersion = "0.52.0"

assert.NoError(t, cfg.Validate())
require.NoError(t, GenerateAndCompile(cfg))

// Sleep for 1 second to make sure all processes using the files are completed
// (on Windows fail to delete temp dir otherwise).
time.Sleep(1 * time.Second)
}

0 comments on commit 542c441

Please sign in to comment.