Skip to content

Commit

Permalink
fix wrong assert/require merge
Browse files Browse the repository at this point in the history
  • Loading branch information
dmathieu committed Sep 18, 2024
1 parent 9a8b8a7 commit 95a1288
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions exporter/exporterhelper/internal/batch_sender_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,8 @@ func TestBatchSender_ShutdownDeadlock(t *testing.T) {
sink := newFakeRequestSink()

// Send 2 concurrent requests
go func() { require.NoError(t, be.Send(context.Background(), &fakeRequest{items: 4, sink: sink})) }()
go func() { require.NoError(t, be.Send(context.Background(), &fakeRequest{items: 4, sink: sink})) }()
go func() { assert.NoError(t, be.Send(context.Background(), &fakeRequest{items: 4, sink: sink})) }()
go func() { assert.NoError(t, be.Send(context.Background(), &fakeRequest{items: 4, sink: sink})) }()

// Wait for the requests to enter the merge function
<-waitMerge
Expand Down Expand Up @@ -591,7 +591,7 @@ func TestBatchSenderWithTimeout(t *testing.T) {
for i := 0; i < 3; i++ {
wg.Add(1)
go func() {
require.NoError(t, be.Send(context.Background(), &fakeRequest{items: 4, sink: sink}))
assert.NoError(t, be.Send(context.Background(), &fakeRequest{items: 4, sink: sink}))
wg.Done()
}()
}
Expand Down

0 comments on commit 95a1288

Please sign in to comment.