Skip to content

Commit

Permalink
ExtensionDefaultConfigFunc should be ExtensionCreateDefaultConfigFunc…
Browse files Browse the repository at this point in the history
… - Issue#5437
  • Loading branch information
rice-junhaoyu committed Jun 1, 2022
1 parent 58b1466 commit f51c8fd
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions component/extension.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ type ExtensionCreateSettings struct {
BuildInfo BuildInfo
}

// ExtensionDefaultConfigFunc is the equivalent of component.ExtensionFactory.CreateDefaultConfig()
type ExtensionDefaultConfigFunc func() config.Extension
// ExtensionCreateDefaultConfigFunc is the equivalent of component.ExtensionFactory.CreateDefaultConfig()
type ExtensionCreateDefaultConfigFunc func() config.Extension

// CreateDefaultConfig implements ExtensionFactory.CreateDefaultConfig()
func (f ExtensionDefaultConfigFunc) CreateDefaultConfig() config.Extension {
func (f ExtensionCreateDefaultConfigFunc) CreateDefaultConfig() config.Extension {
return f()
}

Expand Down Expand Up @@ -87,17 +87,17 @@ type ExtensionFactory interface {

type extensionFactory struct {
baseFactory
ExtensionDefaultConfigFunc
ExtensionCreateDefaultConfigFunc
CreateExtensionFunc
}

func NewExtensionFactory(
cfgType config.Type,
createDefaultConfig ExtensionDefaultConfigFunc,
createDefaultConfig ExtensionCreateDefaultConfigFunc,
createServiceExtension CreateExtensionFunc) ExtensionFactory {
return &extensionFactory{
baseFactory: baseFactory{cfgType: cfgType},
ExtensionDefaultConfigFunc: createDefaultConfig,
CreateExtensionFunc: createServiceExtension,
baseFactory: baseFactory{cfgType: cfgType},
ExtensionCreateDefaultConfigFunc: createDefaultConfig,
CreateExtensionFunc: createServiceExtension,
}
}

0 comments on commit f51c8fd

Please sign in to comment.