Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support attribute_group-typed semantic conventions in semconv #10072

Closed
dashpole opened this issue May 2, 2024 · 0 comments · Fixed by #10075
Closed

Support attribute_group-typed semantic conventions in semconv #10072

dashpole opened this issue May 2, 2024 · 0 comments · Fixed by #10075

Comments

@dashpole
Copy link
Contributor

dashpole commented May 2, 2024

Is your feature request related to a problem? Please describe.

I'm interested in server.address, server.port, and url.scheme to fix open-telemetry/opentelemetry-collector-contrib#32814.

Describe the solution you'd like

The semconv packages don't appear to include attribute_group-typed conventions. I believe this is because the attribute_group type is not part of the semconvgen Makefile target:

# Generate semantic convention constants. Requires a clone of the opentelemetry-specification repo
gensemconv: $(SEMCONVGEN) $(SEMCONVKIT)
@[ "${SPECPATH}" ] || ( echo ">> env var SPECPATH is not set"; exit 1 )
@[ "${SPECTAG}" ] || ( echo ">> env var SPECTAG is not set"; exit 1 )
@echo "Generating semantic convention constants from specification version ${SPECTAG} at ${SPECPATH}"
$(SEMCONVGEN) -o semconv/${SPECTAG} -t semconv/template.j2 -s ${SPECTAG} -i ${SPECPATH}/model/. --only=resource -p conventionType=resource -f generated_resource.go
$(SEMCONVGEN) -o semconv/${SPECTAG} -t semconv/template.j2 -s ${SPECTAG} -i ${SPECPATH}/model/. --only=event -p conventionType=event -f generated_event.go
$(SEMCONVGEN) -o semconv/${SPECTAG} -t semconv/template.j2 -s ${SPECTAG} -i ${SPECPATH}/model/. --only=span -p conventionType=trace -f generated_trace.go
$(SEMCONVKIT) -output "semconv/$(SPECTAG)" -tag "$(SPECTAG)"

codeboten added a commit to codeboten/opentelemetry-collector that referenced this issue May 2, 2024
Include attribute_group as requested.

Fixes open-telemetry#10072

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit that referenced this issue May 2, 2024
Include attribute_group as requested.

Fixes #10072

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this issue May 27, 2024
Include attribute_group as requested.

Fixes open-telemetry#10072

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant