Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCB v0.107.0 and onward no longer report version on command line #11220

Closed
jackgopack4 opened this issue Sep 19, 2024 · 1 comment · Fixed by #11208
Closed

OCB v0.107.0 and onward no longer report version on command line #11220

jackgopack4 opened this issue Sep 19, 2024 · 1 comment · Fixed by #11208
Labels
bug Something isn't working

Comments

@jackgopack4
Copy link
Contributor

Describe the bug

ocb from v0.107.0 onward reports "devel" as version when running on CLI instead of version number. Confirmed to work in v106.1 and earlier

Steps to reproduce
Download any ocb binary v0.107.0 or later and run ocb version

What did you expect to see?
expect to see ocb version vX.XXX.X

What did you see instead?
instead see `ocb version (devel)

What version did you use?
v0.107.0, v0.108.0, v0.109.0

What config did you use?
n/a

Environment
darwin/arm64, downloaded ocb binary

Additional context
reported in releases repo open-telemetry/opentelemetry-collector-releases#664
PR to re-add code and add unit tests that was removed and causes cli to not report proper build version.
Also requires adding flag in build process, PR open in releases: open-telemetry/opentelemetry-collector-releases#665
@jackgopack4 jackgopack4 added the bug Something isn't working label Sep 19, 2024
@jackgopack4 jackgopack4 mentioned this issue Sep 19, 2024
Merged
@jackgopack4 jackgopack4 changed the title OCB no longer reports version on command line OCB v0.107.0 and onward no longer report version on command line Sep 19, 2024
bogdandrutu pushed a commit that referenced this issue Sep 24, 2024
@jackgopack4
Re-add version code to cmd/builder (#11208)
9811830 
Revert "[chore] delete code to set a version and date, as it it not used
(#10715)"
Remove date string but re-add functions that check for version number
This (mostly) reverts commit b53f57d.

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This re-enables the functionality to set a version number for ocb binary
(cmd/builder). It was erroneously removed. It also adds unit tests for
this functionality, as a warning is given on CI with no code coverage.

<!-- Issue number if applicable -->
#### Link to tracking issue
Relates to
open-telemetry/opentelemetry-collector-releases#664.
Closes #11220 along with
open-telemetry/opentelemetry-collector-releases#665

<!--Describe what testing was performed and which tests were added.-->
#### Testing
ran build and release cycles inside personal fork repositories
(jackgopack4/opentelemetry-collector and
jackgopack4/opentelemetry-collector-releases)
<!--Describe the documentation added.-->
#### Documentation
.chloggen file
<!--Please delete paragraphs that you did not use before submitting.-->
@jackgopack4
Copy link
Contributor Author

open-telemetry/opentelemetry-collector-releases#665 still needs to be merged before this issue will be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-add version code to cmd/builder jackgopack4/opentelemetry-collector
1 participant
@jackgopack4