Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.15 compatiblity #1820

Closed
albertteoh opened this issue Sep 21, 2020 · 1 comment
Closed

Go 1.15 compatiblity #1820

albertteoh opened this issue Sep 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@albertteoh
Copy link
Contributor

Describe the bug
Similar issue to the one discovered in jaegertracing/jaeger#2435, whereby certificates are generated using the Common Name field, instead of SANs.

Steps to reproduce

$ go version
go version go1.14.9 darwin/amd64

$ go test -run TestHttpReception ./config/configgrpc
ok  	go.opentelemetry.io/collector/config/configgrpc	6.168s

# Switch to go 1.15.1
$ go version
go version go1.15.1 darwin/amd64

$ go test -run TestHttpReception ./config/configgrpc
--- FAIL: TestHttpReception (10.03s)
    --- FAIL: TestHttpReception/TLS (2.00s)
        configgrpc_test.go:418:
            	Error Trace:	configgrpc_test.go:418
            	Error:      	Received unexpected error:
            	            	rpc error: code = DeadlineExceeded desc = latest balancer error: connection error: desc = "transport: authentication handshake failed: x509: certificate is valid for foo, not localhost"
            	Test:       	TestHttpReception/TLS
        configgrpc_test.go:419:
            	Error Trace:	configgrpc_test.go:419
            	Error:      	Expected value not to be nil.
            	Test:       	TestHttpReception/TLS
    --- FAIL: TestHttpReception/mTLS (2.01s)
        configgrpc_test.go:418:
            	Error Trace:	configgrpc_test.go:418
            	Error:      	Received unexpected error:
            	            	rpc error: code = DeadlineExceeded desc = latest balancer error: connection error: desc = "transport: authentication handshake failed: x509: certificate is valid for foo, not localhost"
            	Test:       	TestHttpReception/mTLS
        configgrpc_test.go:419:
            	Error Trace:	configgrpc_test.go:419
            	Error:      	Expected value not to be nil.
            	Test:       	TestHttpReception/mTLS
FAIL
FAIL	go.opentelemetry.io/collector/config/configgrpc	10.245s
FAIL

What did you expect to see?
Tests to pass with Go 1.15.

What did you see instead?
Failing tests for:

  • go.opentelemetry.io/collector/config/configgrpc
  • go.opentelemetry.io/collector/config/confighttp
  • go.opentelemetry.io/receiver/jaegerreceiver

What version did you use?
Version: master HEAD

What config did you use?
Config: N/A

Environment
OS: MacOS
Compiler(if manually compiled): go 1.15.1

Additional context
I propose to add a script (similar to jaegertracing/jaeger#2461) that will provide a self-documenting means of generating certs for now and in future, which is configurable enough to generate certs for each of the above failing tests via a Makefile target: make cert. If maintainers agree with this proposal, where should this script belong?

@albertteoh albertteoh added the bug Something isn't working label Sep 21, 2020
@bogdandrutu
Copy link
Member

https://github.com/open-telemetry/opentelemetry-collector/tree/master/internal/buildscripts

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
…y#1820)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.40 to 1.24.42.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.40...1.24.42)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants