Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: lots of boilerplate code in extension implementations #308

Closed
pjanotti opened this issue Aug 29, 2019 · 1 comment
Closed

Refactor: lots of boilerplate code in extension implementations #308

pjanotti opened this issue Aug 29, 2019 · 1 comment
Milestone
Backlog

Comments

@pjanotti
Copy link
Contributor

After coding the 3 core extensions (health-check, pprof, zPages) it become clear that the code for them is very similar and can be refactored to reduced code repetition. The one that is slightly different is the health-check that is implemented using a package for Jaeger, having an OTelSvc implementation for health-check (#307) can help having it using the same code pattern.
@pjanotti pjanotti mentioned this issue Aug 29, 2019
Merged
@ibawt ibawt mentioned this issue Oct 29, 2019
Closed
3 tasks
@tigrannajaryan tigrannajaryan added this to the Backlog milestone Jul 30, 2020
@bogdandrutu
Copy link
Member

Obsolete, we have extensionhelper

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@bogdandrutu
Remove myself from CODEOWNERS (open-telemetry#308)
2950978 
I am not capable of reviewing any important PR in this repo, and cannot follow everything that happens.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@pjanotti
Fix named config sources (open-telemetry#308)
b76a364 
* Fix handling of named config sources
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@TylerHelmuth
add opentelemetry-demo to example targets (open-telemetry#308)
e6de7a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@bogdandrutu @tigrannajaryan @pjanotti