Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheusremotewrite exporter should use "pdata" not internal protos #3108

Closed
bogdandrutu opened this issue May 5, 2021 · 6 comments · Fixed by #3184
Closed

Prometheusremotewrite exporter should use "pdata" not internal protos #3108

bogdandrutu opened this issue May 5, 2021 · 6 comments · Fixed by #3184
Assignees
@alolita @sincejune
Labels
area:exporter bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone
Phase1-Trace-GA-R...

Comments

@bogdandrutu
Copy link
Member

See https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/prometheusremotewriteexporter/exporter.go#L106

We should not depend on the internal representation in any component.
@bogdandrutu bogdandrutu added the bug Something isn't working label May 5, 2021
@bogdandrutu bogdandrutu added this to the Phase2-GA-Roadmap milestone May 5, 2021
@bogdandrutu bogdandrutu added good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up labels May 5, 2021
@bogdandrutu
Copy link
Member Author

Assigned to @alolita for triage

@sincejune
Copy link
Contributor

I think I can take it.

@bogdandrutu
Copy link
Member Author

@sincejune go for it, waiting for a PR :)

@alolita
Copy link
Member

alolita commented May 12, 2021

@sincejune do you have bandwidth to submit a PR? else I will assign to another engineer? Please let us know.

@sincejune
Copy link
Contributor

sincejune commented May 12, 2021 •
edited
Loading

@alolita sorry, I was fighting with the unit tests under Prometheusremotewrite exporter. I think I can raise a PR within 2~3 days :)

@sincejune sincejune mentioned this issue May 14, 2021
Merged
@bogdandrutu
Copy link
Member Author

This is important for phase one because it blocks #3104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alolita alolita

@sincejune sincejune

Labels
area:exporter bug Something isn't working good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
Phase1-Trace-GA-Roadmap
Development

Successfully merging a pull request may close this issue.

Remove internal protos usage in Prometheusremotewrite exporter sincejune/opentelemetry-collector
3 participants
@bogdandrutu @alolita @sincejune