Remove internal protos usage in Prometheusremotewrite exporter #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
May 14, 2021
| func (prwe *PrwExporter) handleScalarMetric(tsMap map[string]*prompb.TimeSeries, resource resourcev1.Resource, metric *otlp.Metric) error { | ||
| switch metric.Data.(type) { | ||
| func (prwe *PrwExporter) handleScalarMetric(tsMap map[string]*prompb.TimeSeries, resource pdata.Resource, metric pdata.Metric) error { | ||
| switch metric.DataType() { |
There was a problem hiding this comment.
Probably we can get rid of this and embed directly into the previous switch in PushMetrics. Let's do this in the next PR please :)
There was a problem hiding this comment.
Filed PR here: #3261
Frefreak
pushed a commit
to Frefreak/opentelemetry-collector
that referenced
this pull request
May 15, 2021
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
ankitnayan
pushed a commit
to SigNoz/opentelemetry-collector
that referenced
this pull request
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove internal protos usage in Prometheusremotewrite exporter, closes #3108