Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstrumentationLibrary<signal>ToScope functions shouldn't be exported #5163

Closed
dmitryax opened this issue Apr 6, 2022 · 0 comments · Fixed by #5164
Closed

InstrumentationLibrary<signal>ToScope functions shouldn't be exported #5163

dmitryax opened this issue Apr 6, 2022 · 0 comments · Fixed by #5164
Milestone
go.opentelemetry....

Comments

@dmitryax
Copy link
Member

dmitryax commented Apr 6, 2022 •
edited
Loading

Recently added functions for backward compatible OTLP unmashalling (example) are publicly exported. They accept an argument of unexported type, so the functions are useless outside of collector/model module. Therefore they should not be part of public API and should be put in model/internal package.
@dmitryax dmitryax added the bug Something isn't working label Apr 6, 2022
@dmitryax dmitryax removed the bug Something isn't working label Apr 6, 2022
@dmitryax dmitryax mentioned this issue Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
go.opentelemetry.io/collector/pdata 1.0
Development

Successfully merging a pull request may close this issue.

Make InstrumentationLibrary<signal>ToScope functions unexported dmitryax/opentelemetry-collector
1 participant
@dmitryax