Make InstrumentationLibrary<signal>ToScope functions unexported #5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
hide-otlp-compatibility-functions
branch
from
cb130d9
to
28cc732
Compare
Codecov Report
@@ Coverage Diff @@
## main #5164 +/- ##
=======================================
Coverage 90.33% 90.33%
=======================================
Files 182 185 +3
Lines 11000 11000
=======================================
Hits 9937 9937
Misses 837 837
Partials 226 226
Continue to review full report at Codecov.
|
The functions were added in the the latest version. They are intended for the internal use only and shouldn't be exported.
dmitryax
force-pushed
the
hide-otlp-compatibility-functions
branch
from
28cc732
to
4b75c6a
Compare
bogdandrutu
approved these changes
Apr 7, 2022
mx-psi
approved these changes
Apr 7, 2022
codeboten
approved these changes
Apr 7, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…-telemetry#5164) The functions were added in the the latest version. They are intended for the internal use only and shouldn't be exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions were added in the the latest release. They are intended for the internal use only and shouldn't be exported.
This change is applied without backward compatibility because the functions accept an argument of internal type and cannot be used outside of
collector/model. If we keep backward compatibility here, we would also have to export these functions additionally in the new structure defined in #5087.Closes: #5163