Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[component] component.go - review ErrNilNextConsumer #9322

Closed
atoulme opened this issue Jan 20, 2024 · 0 comments · Fixed by #9779
Closed

[component] component.go - review ErrNilNextConsumer #9322

atoulme opened this issue Jan 20, 2024 · 0 comments · Fixed by #9779
Labels
area:component
Milestone
go.opentelemetry....

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 20, 2024

ErrNilNextConsumer is an error exposed by the component package.

In what situations can this error actually be thrown, ie, when is the next consumer ever nil?
Would it be possible to do away with this error? Would it make sense to have a check before the component is initialized instead?
This was referenced Mar 17, 2024
Merged
Merged
dmitryax pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Mar 19, 2024
@atoulme
Remove checks of ErrNilNextConsumer (#31793)
8fd3a47 
**Description:**
Remove explicit checks in all receivers to check if the next consumer is
nil.
The nil check is now done by the pipeline builder.

This is a follow up of
open-telemetry/opentelemetry-collector#9322.

This PR blocks
open-telemetry/opentelemetry-collector#9779.
dmitryax pushed a commit that referenced this issue Mar 20, 2024
@atoulme
[component] Remove deprecated error ErrNilNextConsumer (#9779)
4df2af2 
**Description:** 
Remove deprecated error `ErrNilNextConsumer`

**Link to tracking Issue:**
Fixes #9322
@lekaf974 lekaf974 mentioned this issue Mar 30, 2024
Closed
@tarsojabbes tarsojabbes mentioned this issue Apr 4, 2024
Merged
@tuturiffic tuturiffic mentioned this issue Apr 18, 2024
Closed
@braydonk braydonk mentioned this issue May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:component
Projects
Collector: v1
Archived in project
Milestone
go.opentelemetry.io/collector/compone...
Development

Successfully merging a pull request may close this issue.

[component] Remove deprecated error ErrNilNextConsumer atoulme/opentelemetry-collector
2 participants
@atoulme @TylerHelmuth